Skip to content

Drivers: max17055: retrieve the current value #93034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Drivers: max17055: retrieve the current value #93034

wants to merge 1 commit into from
+17 −0

Conversation

samueltardieu
Copy link
Contributor

@samueltardieu samueltardieu commented Jul 11, 2025 •
edited
Loading

The MAX17055 peripheral allows measuring the current value (which corresponds to the instantaneous value). Respond to the SENSOR_CHAN_CURRENT command, and retrieve the data from the 0x0a device register.

@github-actions github-actions bot added area: Sensors Sensors platform: ADI Analog Devices, Inc. labels Jul 11, 2025
ubieda
ubieda previously approved these changes Jul 11, 2025
View reviewed changes
Copy link
Member

@ubieda ubieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please fix CI

@samueltardieu
Copy link
Contributor Author

Looks good, but please fix CI

I switched it to a private MAX17055 extension, as was done already for the open-circuit voltage. This should also fix the CI.

@ubieda
Copy link
Member

ubieda commented Jul 14, 2025

@samueltardieu it seems there's still some CI issues.

@samueltardieu
Copy link
Contributor Author

samueltardieu commented Jul 14, 2025 •
edited
Loading

@samueltardieu it seems there's still some CI issues.

Yes (a "decasting" of the enum to an integer type or similar was missing to avoid a warning), and that was a good thing: in the meantime, I noticed I could use SENSOR_CHAN_CURRENT instead of defining a new enum value, as is done in the npm13xx_charger and some others sensors already.

Updating the PR!

@samueltardieu
Copy link
Contributor Author

I am puzzled with the CI failure which seems unrelated to this PR:

INFO    - 1019/1019 qemu_x86_64/atom          sample.kernel.bootargs.efi                         FAILED unexpected eof (qemu 6.919s <zephyr>)

@ubieda
Copy link
Member

ubieda commented Jul 14, 2025

Would you mind rebasing to latest upstream/main?

@samueltardieu
Copy link
Contributor Author

Would you mind rebasing to latest upstream/main?

Done.

@samueltardieu
Drivers: max17055: retrieve the current value
506ab5c 
The MAX17055 peripheral allows measuring the current
value (which corresponds to the instantaneous value). Respond to
the `SENSOR_CHAN_CURRENT` command, and retrieve the data
from the `0x0a` device register.

Signed-off-by: Samuel Tardieu <sam@rfc1149.net>
@samueltardieu
Copy link
Contributor Author

(and updated the description)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ubieda ubieda ubieda approved these changes

@asemjonovs asemjonovs Awaiting requested review from asemjonovs

@avisconti avisconti Awaiting requested review from avisconti

@galak galak Awaiting requested review from galak

@jeppenodgaard jeppenodgaard Awaiting requested review from jeppenodgaard

@MaureenHelm MaureenHelm Awaiting requested review from MaureenHelm

@microbuilder microbuilder Awaiting requested review from microbuilder

@ozersa ozersa Awaiting requested review from ozersa

@teburd teburd Awaiting requested review from teburd

@tristan-google tristan-google Awaiting requested review from tristan-google

@ttmut ttmut Awaiting requested review from ttmut

@yasinustunerg yasinustunerg Awaiting requested review from yasinustunerg

@yperess yperess Awaiting requested review from yperess

At least 2 approving reviews are required to merge this pull request.

Assignees

@MaureenHelm MaureenHelm

Labels
area: Sensors Sensors platform: ADI Analog Devices, Inc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samueltardieu @ubieda @MaureenHelm